[clangd] give project config higher precedence than user config #129454
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
1 participant
Changing the order of the provider stack to place project config higher lets a project config override elements of the user config rather than the other way around.
Discussed in clangd/clangd#1193. I've been using a build with this change off and on since asking about it there and haven't had any trouble from it. Any reason to resist this change - some rationale behind the current behavior that I've overlooked, or something that won't work right with just this +2/-2 diff?
created this PR as a draft, going to leave it that way until I have a PR open in llvm/clangd-www to update the docs accordingly.